forked from gfx-rs/wgpu
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ray tracing #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in 0a76c0f.
Consolidate the explanation of buffer mapping in the documentation for `Buffer`. Change the example code to actually compile, given that the `map_async` callback needs to share access to the buffer with `map_async`'s caller. Mapping isn't pretty, but covering that up in the docs doesn't improve matters. For `BufferSlice`, `BufferView`, and `BufferViewMut`, consolidate extended explanations and background in the docs for types, rather than scattering it around in the docs for associated functions. For `Buffer::slice`, `BufferSlice::get_mapped_range`, and `BufferSlice::get_mapped_range_mut`, update documentation to provide necessary details, but defer to types' docs for background.
These are in nightly builds.
naga doesn't have a `serde` feature, instead having separate `serialize` and `deserialize` features, so things that want to modify the serde handling must check for either of those, not for `serde` itself.
* Add missing changelog entry for `msl-out-if-target-apple`/`hlsl-out-if-target-windows` feature addition * minor changelog reorganisation * fix missing author attribution & pr link in changelog * import patch release changelogs and remove redundant items * move pipeline overridable constants from bugfixes to features
The current code works, but `serde` documents that the feature to use is `derive` (which then happens to use the `serde_derive` implicit feature).
This helps to prepare for the coming day when explicit features will be required.
…g mapped_at_creation buffers This issue was introduced by fabbca2.
We should have always unmapped the staging buffer as we are using it on the GPU after this point.
It's already documented that to unmap a buffer it has to have been mapped. Vulkan was the only backend that was returning an OOM on missing `Buffer.block` but `Buffer.map_buffer` already returns an error in this case.
In `naga::back:hlsl`: - Generate calls to `Interlocked{op}64` when necessary. not `Interlocked{op}`. - Make atomic operations that do not produce a value emit their operands properly. In the Naga snapshot tests: - Adapt `atomicOps-int64-min-max.wgsl` to include cases that cover non-trivial atomic operation operand emitting. In `wgpu_hal::vulkan::adapter`: - When retrieving physical device features, be sure to include the `PhysicalDeviceShaderAtomicInt64Features` extending struct in the chain whenever the `VK_KHR_shader_atomic_int64` extension is available. - Request both `shader_{buffer,shared}_int64_atomics` in the `PhysicalDeviceShaderAtomicInt64Features` extending struct when either of `wgpu_types::Features::SHADER_INT64_ATOMIC_{ALL_OPS,MIN_MAX}` is requested. --------- Co-authored-by: Jim Blandy <[email protected]>
* build(deps): bump crate-ci/typos from 1.22.9 to 1.23.1 Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * typo fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andreas Reich <[email protected]>
Adds a benchmark for compute pass recording, very similar to what we have for render passes.
…updates (gfx-rs#5944) * build(deps): bump the patch-updates group across 1 directory with 23 updates Bumps the patch-updates group with 18 updates in the / directory: | Package | From | To | | --- | --- | --- | | [document-features](https://github.com/slint-ui/document-features) | `0.2.8` | `0.2.9` | | [glam](https://github.com/bitshifter/glam-rs) | `0.27.0` | `0.28.0` | | [serde](https://github.com/serde-rs/serde) | `1.0.203` | `1.0.204` | | [serde_json](https://github.com/serde-rs/json) | `1.0.119` | `1.0.120` | | [metal](https://github.com/gfx-rs/metal-rs) | `0.28.0` | `0.29.0` | | [syn](https://github.com/dtolnay/syn) | `2.0.68` | `2.0.70` | | [ab_glyph](https://github.com/alexheretic/ab-glyph) | `0.2.27` | `0.2.28` | | [async-trait](https://github.com/dtolnay/async-trait) | `0.1.80` | `0.1.81` | | [cc](https://github.com/rust-lang/cc-rs) | `1.0.103` | `1.1.0` | | [clap](https://github.com/clap-rs/clap) | `4.5.8` | `4.5.9` | | [deno_unsync](https://github.com/denoland/deno_unsync) | `0.3.5` | `0.3.10` | | oorandom | `11.1.3` | `11.1.4` | | [tinyvec](https://github.com/Lokathor/tinyvec) | `1.6.1` | `1.8.0` | | [unicode-id-start](https://github.com/Boshen/unicode-id-start) | `1.1.2` | `1.2.0` | | [uuid](https://github.com/uuid-rs/uuid) | `1.9.1` | `1.10.0` | | [wayland-backend](https://github.com/smithay/wayland-rs) | `0.3.4` | `0.3.5` | | [windows_i686_gnullvm](https://github.com/microsoft/windows-rs) | `0.52.5` | `0.52.6` | | [zerocopy](https://github.com/google/zerocopy) | `0.7.34` | `0.7.35` | Updates `document-features` from 0.2.8 to 0.2.9 - [Release notes](https://github.com/slint-ui/document-features/releases) - [Changelog](https://github.com/slint-ui/document-features/blob/master/CHANGELOG.md) - [Commits](slint-ui/document-features@v0.2.8...v0.2.9) Updates `glam` from 0.27.0 to 0.28.0 - [Changelog](https://github.com/bitshifter/glam-rs/blob/main/CHANGELOG.md) - [Commits](bitshifter/glam-rs@0.27.0...0.28.0) Updates `serde` from 1.0.203 to 1.0.204 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.203...v1.0.204) Updates `serde_json` from 1.0.119 to 1.0.120 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.119...v1.0.120) Updates `metal` from 0.28.0 to 0.29.0 - [Release notes](https://github.com/gfx-rs/metal-rs/releases) - [Commits](https://github.com/gfx-rs/metal-rs/commits) Updates `syn` from 2.0.68 to 2.0.70 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.68...2.0.70) Updates `ab_glyph` from 0.2.27 to 0.2.28 - [Release notes](https://github.com/alexheretic/ab-glyph/releases) - [Commits](alexheretic/ab-glyph@ab-glyph-0.2.27...ab-glyph-0.2.28) Updates `async-trait` from 0.1.80 to 0.1.81 - [Release notes](https://github.com/dtolnay/async-trait/releases) - [Commits](dtolnay/async-trait@0.1.80...0.1.81) Updates `cc` from 1.0.103 to 1.1.0 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.0.103...cc-v1.1.0) Updates `clap` from 4.5.8 to 4.5.9 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.8...v4.5.9) Updates `clap_builder` from 4.5.8 to 4.5.9 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.5.8...v4.5.9) Updates `deno_unsync` from 0.3.5 to 0.3.10 - [Commits](https://github.com/denoland/deno_unsync/commits) Updates `oorandom` from 11.1.3 to 11.1.4 Updates `owned_ttf_parser` from 0.21.0 to 0.24.0 - [Release notes](https://github.com/alexheretic/owned-ttf-parser/releases) - [Changelog](https://github.com/alexheretic/owned-ttf-parser/blob/main/CHANGELOG.md) - [Commits](alexheretic/owned-ttf-parser@0.21.0...0.24.0) Updates `serde_derive` from 1.0.203 to 1.0.204 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.203...v1.0.204) Updates `tinyvec` from 1.6.1 to 1.8.0 - [Changelog](https://github.com/Lokathor/tinyvec/blob/main/CHANGELOG.md) - [Commits](Lokathor/tinyvec@v1.6.1...v1.8.0) Updates `ttf-parser` from 0.21.1 to 0.24.0 - [Changelog](https://github.com/RazrFalcon/ttf-parser/blob/master/CHANGELOG.md) - [Commits](harfbuzz/ttf-parser@v0.21.1...v0.24.0) Updates `unicode-id-start` from 1.1.2 to 1.2.0 - [Commits](https://github.com/Boshen/unicode-id-start/commits) Updates `uuid` from 1.9.1 to 1.10.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@1.9.1...1.10.0) Updates `wayland-backend` from 0.3.4 to 0.3.5 - [Release notes](https://github.com/smithay/wayland-rs/releases) - [Changelog](https://github.com/Smithay/wayland-rs/blob/master/historical_changelog.md) - [Commits](https://github.com/smithay/wayland-rs/commits) Updates `windows_i686_gnullvm` from 0.52.5 to 0.52.6 - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) Updates `zerocopy` from 0.7.34 to 0.7.35 - [Release notes](https://github.com/google/zerocopy/releases) - [Changelog](https://github.com/google/zerocopy/blob/main/CHANGELOG.md) - [Commits](https://github.com/google/zerocopy/commits) Updates `zerocopy-derive` from 0.7.34 to 0.7.35 - [Release notes](https://github.com/google/zerocopy/releases) - [Changelog](https://github.com/google/zerocopy/blob/main/CHANGELOG.md) - [Commits](https://github.com/google/zerocopy/commits) --- updated-dependencies: - dependency-name: document-features dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: glam dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: metal dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: ab_glyph dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: async-trait dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: cc dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: clap dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: clap_builder dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: deno_unsync dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: oorandom dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: owned_ttf_parser dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: serde_derive dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: tinyvec dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: ttf-parser dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: unicode-id-start dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: uuid dependency-type: indirect update-type: version-update:semver-minor dependency-group: patch-updates - dependency-name: wayland-backend dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: windows_i686_gnullvm dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: zerocopy dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: zerocopy-derive dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates ... Signed-off-by: dependabot[bot] <[email protected]> * Update encase to resolve glam dependency issue --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andreas Reich <[email protected]>
Ensure that samplers using non-`Nearest` mipmap filtering are considered "filtering samplers" when deciding bind group layout compatibility. Add tests for layout `NonFiltering` validation. Fixes gfx-rs#5948.
Bumps the patch-updates group with 6 updates: | Package | From | To | | --- | --- | --- | | [document-features](https://github.com/slint-ui/document-features) | `0.2.9` | `0.2.10` | | [thiserror](https://github.com/dtolnay/thiserror) | `1.0.61` | `1.0.62` | | [syn](https://github.com/dtolnay/syn) | `2.0.70` | `2.0.71` | | [bytes](https://github.com/tokio-rs/bytes) | `1.6.0` | `1.6.1` | | [cc](https://github.com/rust-lang/cc-rs) | `1.1.0` | `1.1.5` | | [thiserror-impl](https://github.com/dtolnay/thiserror) | `1.0.61` | `1.0.62` | Updates `document-features` from 0.2.9 to 0.2.10 - [Release notes](https://github.com/slint-ui/document-features/releases) - [Changelog](https://github.com/slint-ui/document-features/blob/master/CHANGELOG.md) - [Commits](https://github.com/slint-ui/document-features/commits) Updates `thiserror` from 1.0.61 to 1.0.62 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.61...1.0.62) Updates `syn` from 2.0.70 to 2.0.71 - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.70...2.0.71) Updates `bytes` from 1.6.0 to 1.6.1 - [Release notes](https://github.com/tokio-rs/bytes/releases) - [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md) - [Commits](tokio-rs/bytes@v1.6.0...v1.6.1) Updates `cc` from 1.1.0 to 1.1.5 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.1.0...cc-v1.1.5) Updates `thiserror-impl` from 1.0.61 to 1.0.62 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.61...1.0.62) --- updated-dependencies: - dependency-name: document-features dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: bytes dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: cc dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates - dependency-name: thiserror-impl dependency-type: indirect update-type: version-update:semver-patch dependency-group: patch-updates ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.1 to 1.23.2. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.23.1...v1.23.2) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ffects from there leading to boxing of almost all hal resources
gfx_select macros are empty husks now that are waiting to be removed
…cing-updated # Conflicts: # wgpu-core/src/binding_model.rs # wgpu-core/src/command/compute.rs # wgpu-core/src/command/mod.rs # wgpu-core/src/command/render.rs # wgpu-core/src/device/global.rs # wgpu-core/src/device/queue.rs # wgpu-core/src/device/resource.rs # wgpu-core/src/hub.rs # wgpu-core/src/track/mod.rs # wgpu/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Updates ray tracing to the latest version of wgpu, this incudes degenerification as a major update gfx-rs#6100
Testing
runs on all examples + ray-tracing-get-vertex examples + my WIP ray-tracer
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests. done by CICHANGELOG.md
. See simple instructions inside file. part of [wgpu-core] Inline RayQuery Support gfx-rs/wgpu#3631